fix(core): ModuleRef#get and #resolve opts default values #10822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
when suppling an empty object as options to
ModuleRef#get
andModuleRef#resolve
methods, defaults options are not taking in countWhat is the new behavior?
I also fixed the type def for the second args of
ModuleRef#get
/ModuleRef#resolve
since it shouldn't beGetOrResolveOptions
because that interface is saying that the default value ofstrict
isfalse
, which is wrong forModuleRef
while it's correct forNestApplicationContext
.nest/packages/common/interfaces/nest-application-context.interface.ts
Lines 6 to 11 in 95e096f
Does this PR introduce a breaking change?
it's a breaking changes for those there are using
ModuleRef#get
/ModuleRef#resolve
wrongly.