Merge pull request #13883 from nestjs/fix/nats-client-promise-13880

fix(microservices): hold nats client connection promise ref
nestjs · Aug 13, 2024 · 7468810 · 7468810
2 parents e1f1aa9 + 0c84c7e
commit 7468810
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/microservices/client/client-nats.ts b/packages/microservices/client/client-nats.ts
@@ -18,6 +18,7 @@ let natsPackage = {} as any;
 export class ClientNats extends ClientProxy {
   protected readonly logger = new Logger(ClientNats.name);
   protected natsClient: Client;
+  protected clientConnectionPromise: Promise<Client>;
 
   constructor(protected readonly options: NatsOptions['options']) {
     super();
@@ -30,13 +31,15 @@ export class ClientNats extends ClientProxy {
   public async close() {
     await this.natsClient?.close();
     this.natsClient = null;
+    this.clientConnectionPromise = null;
   }
 
   public async connect(): Promise<any> {
-    if (this.natsClient) {
-      return this.natsClient;
+    if (this.clientConnectionPromise) {
+      return this.clientConnectionPromise;
     }
-    this.natsClient = await this.createClient();
+    this.clientConnectionPromise = this.createClient();
+    this.natsClient = await this.clientConnectionPromise;
     this.handleStatusUpdates(this.natsClient);
     return this.natsClient;
   }

diff --git a/packages/microservices/test/client/client-nats.spec.ts b/packages/microservices/test/client/client-nats.spec.ts
@@ -253,6 +253,7 @@ describe('ClientNats', () => {
     describe('when is not connected', () => {
       beforeEach(async () => {
         client['natsClient'] = null;
+        client['clientConnectionPromise'] = null;
         await client.connect();
       });
       it('should call "handleStatusUpdatesSpy" once', async () => {