Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swc currently support paths mapping on Windows #2271

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

powerfulyang
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@powerfulyang
Copy link
Author

Detail: swc-project/swc#7806

@kamilmysliwiec
Copy link
Member

LGTM

@MinaFayez9
Copy link

Could you please clarify with which version should we expect this to be fixed ?
I already tried the Release 10.1.17 and still facing the same problems that were reported in the referenced issues

@powerfulyang
Copy link
Author

powerfulyang commented Sep 6, 2023

Could you please clarify with which version should we expect this to be fixed ? I already tried the Release 10.1.17 and still facing the same problems that were reported in the referenced issues

@MinaFayez9
update your @swc/core version to v1.3.81.

or delete your node_modules and package-lock.json file, reinstall dependencies.

@MinaFayez9
Copy link

MinaFayez9 commented Sep 6, 2023

I already had even @swc/core version to v1.3.82
I did what you said again now
I even created a fresh project using nest new then installed swc then run using nest start -b swc
Not working
BTW it was working perfectly fine before this issue arise, and I have no special configurations

@powerfulyang
Copy link
Author

@MinaFayez9 error log and minimal reproducible example

@MinaFayez9
Copy link

I apologize for any inconvenience, but I have already provided the minimal reproduction scenario, which involves creating a new Nest project, adding the SWC, and attempting to run it. These steps are fundamental to setting up a Nest project, and I believe it would be more efficient for you to perform them, as they represent the foundational aspects of project creation.

Regrettably, I perceive this as a bureaucratic process that I am not in favor of. Consequently, I must inform you that I will no longer be actively participating in this discussion, and I will not prioritize running SWC over TSC, as it does not significantly impact the outcome and is more of a nice-to-have feature.

@BlindKai
Copy link

BlindKai commented Sep 9, 2023

For those, who are looking for the solution, please, make sure you read the conversation and the comment: swc-project/swc#7806 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants