fix: flatbuffers offset overflow #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
p2p can't depend directly on Github, we need to publish to crate, may need to write |
doitian
force-pushed
the
flatbuffers_offset_overflow
branch
from
fd1ee80 to
78f0784
Compare
Fix overflow panic when following the offset in malformed flatbuffers. Refs nervosnetwork/cfb#15
Use `make gen-fb` to generate files, and `make clean-fb gen-fb` to regenerate all files.
doitian
force-pushed
the
flatbuffers_offset_overflow
branch
from
78f0784 to
2e5d56a
Compare
doitian
force-pushed
the
flatbuffers_offset_overflow
branch
from
646e5ec to
2712126
Compare
driftluo
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix overflow panic when following the offset in malformed flatbuffers.
Refs nervosnetwork/cfb#15