fix: fix some msg left on buffer #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
fix-message-delay
branch
2 times, most recently
from
8b17626 to
520a358
Compare
driftluo
force-pushed
the
fix-message-delay
branch
from
520a358 to
0c5c1e4
Compare
Merged
doitian
reviewed
Dec 29, 2020
| @@ -176,11 +175,11 @@ where | |||
| } | |||
|
|
|||
| fn poll_flush(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll<io::Result<()>> { | |||
| Pin::new(&mut self.socket).as_mut().poll_flush(cx) | |||
| self.socket.poll_flush_unpin(cx) | |||
There was a problem hiding this comment.
What's the difference?
No difference, may look better
There have been tests, and occasionally failed, but did not pay attention to it, thought it was a problem caused by poor ci machine |
doitian
reviewed
Dec 29, 2020
| @@ -82,6 +82,9 @@ pub struct Session<T> { | |||
| event_sender: Sender<StreamEvent>, | |||
| // For receive events from sub streams | |||
| event_receiver: Receiver<StreamEvent>, | |||
| // The control information must be sent successfully and will not cause memory problems | |||
| unbound_event_sender: UnboundedSender<StreamEvent>, | |||
There was a problem hiding this comment.
unbounded is dangerous, giving a large enough bound channel is better.
There was a problem hiding this comment.
This channel is only used to send control information（window update and close）, there is no possibility of unlimited increase
TheWaWaR
approved these changes
Dec 29, 2020
yangby-cryptape
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_sendjust set data to buffer,flushwill try to write data to inner iocodec write buffer left:
https://github.com/nervosnetwork/tentacle/blob/fix-message-delay/tentacle/src/substream.rs#L427
yamux read buffer left:
https://github.com/nervosnetwork/tentacle/blob/fix-message-delay/yamux/src/stream.rs#L302