Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix win compatible #275

Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix: Fix win compatible #275

merged 1 commit into from
Nov 2, 2020

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Oct 26, 2020 •
edited
Loading

review #273 first

  1. async-std pin async poll on accept won't wake up on Windows, but work on Linux
  2. due to tokio 0.2 connect_std function behaves a bit wrong on windows tokio-rs/tokio#3030, use compatible fn on Windows

@driftluo driftluo requested a review from TheWaWaR as a code owner October 26, 2020 07:49
@driftluo driftluo requested review from a team and quake October 26, 2020 07:49
@driftluo driftluo changed the title fixFix win compatible fix: Fix win compatible Oct 26, 2020
@driftluo driftluo mentioned this pull request Oct 28, 2020
Merged
@driftluo driftluo force-pushed the fix-win-compatible branch 10 times, most recently from 20459a5 to 53f443d Compare October 30, 2020 16:53
@driftluo driftluo merged commit 9cf837a into master Nov 2, 2020
@driftluo driftluo deleted the fix-win-compatible branch November 2, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@TheWaWaR TheWaWaR TheWaWaR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @quake @TheWaWaR