Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make tentacle run on async std #269

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Oct 14, 2020

review #268 first

This PR allows tentacle to run on async-std, and because async-std also integrates wasm-bindgen-futures, this means that when on the wasm platform, not need to encapsulate the corresponding spawn function again.

The extra operation is to put the code of the tentacle library into a sub-folder.

Please note that because the workspace features work is quite weird if you want to enable configurations other than the default feature in this project, such as tokio + generic timer/ async std + any timer, please manually delete the default feature of yamux on yamux/Cargo.toml and then compile.

But as a dependency under non-workspace, it has no effect

@driftluo driftluo requested a review from TheWaWaR as a code owner October 14, 2020 06:16
@driftluo driftluo requested review from a team and xxuejie October 14, 2020 06:16
@driftluo driftluo force-pushed the make-tentacle-run-on-async-std branch 3 times, most recently from 88b3e80 to c4d4b82 Compare October 14, 2020 09:21
@driftluo driftluo mentioned this pull request Oct 15, 2020
14 tasks
@driftluo driftluo force-pushed the make-tentacle-run-on-async-std branch from c4d4b82 to 042de7c Compare October 15, 2020 05:47
@quake
Copy link
Member

quake commented Oct 19, 2020

LGTM, one suggestion, setup CI to check different features:

cargo check --all-targets --features molc,async-timer
cargo check --all-targets --features molc,generic-timer
// etc ...

@driftluo driftluo force-pushed the make-tentacle-run-on-async-std branch from 042de7c to 02c6a17 Compare October 19, 2020 11:33
@driftluo driftluo merged commit 5021edc into master Oct 19, 2020
@driftluo driftluo deleted the make-tentacle-run-on-async-std branch October 19, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants