feat: add before handle #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhangsoledad is assigned as the chief reviewer |
doitian
reviewed
May 23, 2019
| @@ -140,6 +142,8 @@ pub struct MetaBuilder { | |||
| service_handle: ProtocolHandle<Box<dyn ServiceProtocol + Send + 'static>>, | |||
| session_handle: SessionHandleFn, | |||
| select_version: SelectVersionFn, | |||
| before_send: Option<Box<dyn Fn(bytes::Bytes) -> bytes::Bytes + Send + 'static>>, | |||
There was a problem hiding this comment.
What's the choice here that before_send is an Option, but before_receive is a Box<Fn>?
There was a problem hiding this comment.
Because the message has a unified entry, only one fn can be used.
The received is that each protocol in each session has an entry and there is no aggregation, so here need to have a handler that can always generate the exact same function, fn -> Option<fn>.
Each time a protocol open, get a receive fn to it's stream
driftluo
force-pushed
the
add-before-handle
branch
from
7743992 to
ba300b2
Compare
driftluo
force-pushed
the
add-before-handle
branch
from
ba300b2 to
2cc02ef
Compare
doitian
approved these changes
May 23, 2019
TheWaWaR
approved these changes
May 23, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all the handles on the framework are after handles. If you want to use the before operation on the upper layer, it will be very tricky and difficult to maintain.
Just like you want to add a compressed feature to some of the upper layers of the protocol. The current way of coding can only be as shown in nervosnetwork/ckb#859.
The p2p framework is very different from the web framework in that there is a need for broadcasting. If the function of compressing messages is done in the codec, it will waste a lot of CPU time, because the same message will increase the compression time as the number of connections grows.
We need a unified way of handling broadcast messages, not exactly the same as codec, just like global preprocessing. This pr adds two preprocessing methods for each protocol, which makes it easier to preprocess messages.
Good luck to you