Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add codespell #252

Closed
wants to merge 2 commits into from
Closed

ci: add codespell #252

wants to merge 2 commits into from

Conversation

doitian
Copy link
Member

@doitian doitian commented Aug 11, 2021

  • fix spell errors
  • add workflow to check spell

@doitian doitian requested review from quake, xxuejie and a team as code owners August 11, 2021 01:54
keroro520
keroro520 suggested changes Nov 12, 2021
View reviewed changes
.github/workflows/spell.yaml
path: ~/.cache/pip
key: ${{ runner.os }}-pip-spellcheck
restore-keys: |
${{ runner.os }}-pip-spellcheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying executing pip install codespell inside my docker is fast. So why use actions/cache here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy from somewhere

@doitian doitian added the p:could-have Priority: desirable but not necessary label Apr 1, 2022
@doitian doitian changed the title codespell ci ci: add codespell Apr 14, 2022
@doitian doitian closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keroro520 keroro520 keroro520 requested changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake Awaiting requested review from quake quake is a code owner

@xxuejie xxuejie Awaiting requested review from xxuejie xxuejie is a code owner

Assignees
No one assigned
Labels
p:could-have Priority: desirable but not necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doitian @keroro520 @zhangsoledad