Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Asset Accounts UI #3252

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: Asset Accounts UI #3252

merged 2 commits into from
Oct 24, 2024
+27 −22

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan mentioned this pull request Oct 14, 2024
Closed
@Danie0918
Copy link
Collaborator

@Keith-CY @homura @yanguoyu Please have a review.

homura
homura reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the title "Undefined" as expected in the picture?

@yanguoyu
Copy link
Collaborator

Is the title "Undefined" as expected in the picture?

These SUDTs' information isn't set, so it shows as undefined. Undefined is a special value.

@devchenyan devchenyan requested a review from silySuper October 15, 2024 07:43
@silySuper
Copy link
Collaborator

silySuper commented Oct 23, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 11474286888. @silySuper

@Keith-CY Keith-CY added this pull request to the merge queue Oct 24, 2024
Merged via the queue into develop with commit ebcb602 Oct 24, 2024
23 checks passed
@Keith-CY Keith-CY deleted the fix-423 branch October 24, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@silySuper silySuper silySuper approved these changes

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devchenyan @Danie0918 @yanguoyu @silySuper @homura @Keith-CY