Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use lumos to init Buffer #3164

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: Use lumos to init Buffer #3164

merged 1 commit into from
May 22, 2024

Conversation

yanguoyu
Copy link
Collaborator

Buffer.from(string, 'hex') the string value should be started without 0x, so I use Lumos bytes.bytify to init Buffer.

@yanguoyu yanguoyu mentioned this pull request May 22, 2024
Closed
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented May 22, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9187144325. @yanguoyu

@yanguoyu yanguoyu merged commit 7b5c592 into nervosnetwork:rc/v0.116.0 May 22, 2024
8 checks passed
@yanguoyu yanguoyu deleted the fix-sign-message branch May 22, 2024 08:09
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
@yanguoyu @github-actions
@Keith-CY @devchenyan
Merge master into dev (#3168)
a544080 
* chore: Update ckb node assume valid target for rc/v0.116.0.

* chore: update versions and changelogs

* fix: Use hex to avoid unexpected string. (#3162)

* fix: Use lumos to init Buffer (#3164)

* Update Neuron compatibility table (#3158)

feat: Update Neuron compatibility table

Co-authored-by: Keith-CY <Keith-CY@users.noreply.github.com>

* fix: amend transaction when consume cells (#3166)

* docs: add video introduction to v0.116.0 in changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Co-authored-by: Keith-CY <Keith-CY@users.noreply.github.com>
Co-authored-by: devchenyan <sgt39007@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura homura approved these changes

@silySuper silySuper silySuper approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanguoyu @Keith-CY @homura @silySuper