Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support lock window for Neuron #3064

Merged
merged 2 commits into from
Apr 29, 2024
Merged

feat: Support lock window for Neuron #3064

merged 2 commits into from
Apr 29, 2024

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Mar 8, 2024

Refer to Magickbase/neuron-public-issues#318

lock-window.mov

@yanguoyu yanguoyu mentioned this pull request Mar 8, 2024
Closed
@yanguoyu yanguoyu force-pushed the feat-lock-window branch 2 times, most recently from 87c9bcd to 0a8c5cc Compare March 8, 2024 05:01
@Danie0918
Copy link
Collaborator

@homura @devchenyan Please have a review.

@Danie0918
Copy link
Collaborator

@homura Please have a review.

@silySuper
Copy link
Collaborator

silySuper commented Apr 28, 2024 •
edited by github-actions bot
Loading

/package
Packageing failed in 8864545175. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Apr 28, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 8864654721. @silySuper

@silySuper
Copy link
Collaborator

1.UI icon is not aligning to its text,and the border is strange.
截屏2024-04-28 15 57 12

2.The tip need show window.
截屏2024-04-28 16 50 38

截屏2024-04-28 16 05 24

3.Lock window can not support command+L.
截屏2024-04-28 16 32 15

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Apr 29, 2024 •
edited
Loading

@silySuper

1.UI icon is not aligning to its text,and the border is strange.

fixed by 0ccb57b

2.The tip need show window.
image

@Danie0918 should we change the content? I can not find the reply to this comment.

3.Lock window can not support command+L.

@silySuper I download the package from #3064 (comment). And the command +L is available on my Mac. Do you try to click Command + L on Mac or Ctrl + L on Windows?

@Danie0918
Copy link
Collaborator

2.The tip need show window.
image

@Danie0918 should we change the content? I can not find the reply to this comment.

#Magickbase/neuron-public-issues#318 (comment)

PRD：https://cvhb3r.axshare.com/#g=1&p=pin

Yes, 'Neuron's window is locked.' would be better.

@silySuper
Copy link
Collaborator

silySuper commented Apr 29, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 8874064562. @silySuper

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Apr 29, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 8874152463. @yanguoyu

@silySuper
Copy link
Collaborator

silySuper commented Apr 29, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 8874295650. @silySuper

@silySuper
Copy link
Collaborator

1.verified
2.verified

@yanguoyu yanguoyu added this pull request to the merge queue Apr 29, 2024
Merged via the queue into nervosnetwork:develop with commit 128e425 Apr 29, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-lock-window branch April 29, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura approved these changes

@devchenyan devchenyan devchenyan approved these changes

@silySuper silySuper silySuper approved these changes

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yanguoyu @Danie0918 @silySuper @Keith-CY @homura @devchenyan