fix: When address is not enough, stop update localSavedBlockNumber #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/package |
|
The unsigned package can be found at https://github.com/yanguoyu/neuron/actions/runs/8123096389 |
Keith-CY
approved these changes
Apr 18, 2024
packages/neuron-wallet/src/block-sync-renderer/sync/light-synchronizer.ts
Outdated
Show resolved
Hide resolved
yanguoyu
force-pushed
the
fix-light-sync
branch
from
c9c5bf6 to
a6fd561
Compare
|
/package |
|
@devchenyan @homura @silySuper please have a review |
devchenyan
approved these changes
Apr 18, 2024
homura
approved these changes
Apr 18, 2024
yanguoyu
force-pushed
the
fix-light-sync
branch
from
a6fd561 to
474227e
Compare
silySuper
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue from
discordThe reason is the generated address and sync process are not synchronized. So when there is not enough address, the sync process will stop saving
localSavedBlockNumber. Then after the new address is derived, it will start syncing from the right block number.