Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Spanish 'es' translation for wallet and UI functions #3024

Merged
merged 132 commits into from
Jan 17, 2024
Merged

Adds Spanish 'es' translation for wallet and UI functions #3024

merged 132 commits into from
Jan 17, 2024

Conversation

Natixe
Copy link
Contributor

@Natixe Natixe commented Jan 12, 2024

No description provided.

@Natixe
Copy link
Contributor Author

Natixe commented Jan 12, 2024

I haven't finished translating everything yet 👌

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jan 13, 2024 •
edited
Loading

I haven't finished translating everything yet 👌

Hi @Natixe
An open PR can be converted into a draft one when it's WIP
image
And it can be ready for review once everything is set.

@Natixe
Copy link
Contributor Author

Natixe commented Jan 13, 2024

Hey @Keith-CY
Thank you for your feedback as always they are great!
How do I convert it to WIP then?

Natixe and others added 4 commits January 13, 2024 18:35
@Natixe @alejandroRbit
Update packages/neuron-ui/src/locales/es.json
e164ea9 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-ui/src/locales/es.json
2bed358 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-ui/src/locales/es.json
9b8cc29 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-ui/src/locales/es.json
580cb0b 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Natixe and others added 7 commits January 14, 2024 01:02
@Natixe @alejandroRbit
Update packages/neuron-wallet/src/locales/es.ts
2277d0d 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-wallet/src/locales/es.ts
f6e66a4 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-wallet/src/locales/es.ts
7193d82 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-wallet/src/locales/es.ts
540b0da 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-wallet/src/locales/es.ts
a01a681 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-wallet/src/locales/es.ts
ea3988f 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-ui/src/locales/es.json
13cfe07 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
@Natixe @alejandroRbit
Update packages/neuron-ui/src/locales/es.json
3c1c619 
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Keith-CY
Keith-CY approved these changes Jan 14, 2024
View reviewed changes
packages/neuron-ui/src/locales/en.json Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Collaborator

Hey @Keith-CY Thank you for your feedback as always they are great! How do I convert it to WIP then?

Sorry for replying late.

Convert to draft sits beneath the reviewer list.

image

@Natixe
Copy link
Contributor Author

Natixe commented Jan 14, 2024

Haaa ok thanks a lot now I'll be but since the translation is finally finished I don't need it anymore for next time I'll use it !

@Natixe Natixe requested a review from Keith-CY January 15, 2024 23:09
@Keith-CY
Copy link
Collaborator

Keith-CY commented Jan 16, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7537842407. @Keith-CY

@Keith-CY
Copy link
Collaborator

I've verified the functions, thank you @Natixe for your enthusiastic efforts.

@Keith-CY Keith-CY merged commit adf593d into nervosnetwork:develop Jan 17, 2024
10 checks passed
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Natixe @alejandroRbit
@Keith-CY @yanguoyu
Adds Spanish 'es' translation for wallet and UI functions (nervosnetw…
4dc9253 
…ork#3024)

Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandroRbit alejandroRbit alejandroRbit left review comments

@Keith-CY Keith-CY Keith-CY approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@silySuper silySuper Awaiting requested review from silySuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Natixe @Keith-CY @yanguoyu @alejandroRbit