Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ckb-sdk-js from dependency list #2817

Merged
merged 16 commits into from
Sep 8, 2023

Conversation

zhangyouxin
Copy link
Contributor

@zhangyouxin zhangyouxin commented Aug 29, 2023

Description

Resolve: Magickbase/neuron-public-issues#201

This is the last PR of Magickbase/neuron-public-issues#201, finally removed ckb-sdk-js from dependency list, it has changed:

  • fixvec
  • Blake2b implementation
  • rawTransactionToHash
  • ECPairs

@zhangyouxin zhangyouxin marked this pull request as ready for review September 4, 2023 00:47
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@silySuper
Copy link
Collaborator

silySuper commented Sep 5, 2023

/package.
Packaging for test is done in 6079020403. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Sep 5, 2023

/package.
Packaging for test is done in 6081308943. @silySuper

@silySuper
Copy link
Collaborator

@silySuper
Copy link
Collaborator

Verified.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Sep 7, 2023

Please resolve conflicts and merge @zhangyouxin

@zhangyouxin
Copy link
Contributor Author

Please resolve conflicts and merge @zhangyouxin

I'm not authorized to merge this pull request. anybody authorized please give a hand

@yanguoyu yanguoyu added this pull request to the merge queue Sep 8, 2023
Merged via the queue into nervosnetwork:develop with commit 8e28d9d Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ckb-sdk-utils by lumos
5 participants