Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check ckb node update or compatibility #2808

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

yanguoyu
Copy link
Collaborator

All of the scenes should start ckb external.

  1. When Neuron has an updated version, and the running external ckb version is bigger than Neuron's internal ckb version
    This scene can test with Test show update neuron #2807, the external ckb version should be bigger than v0.109.0
image
  1. When the running external ckb version is not compatible with Neuron.
    This scene can be tested with the current pr package, and the external ckb version should not be 0.109 ~ 0.110
image

packages/neuron-ui/src/services/remote/app.ts Outdated Show resolved Hide resolved
packages/neuron-wallet/src/services/node.ts Show resolved Hide resolved
packages/neuron-wallet/src/services/node.ts Outdated Show resolved Hide resolved
packages/neuron-wallet/src/services/node.ts Outdated Show resolved Hide resolved
@yanguoyu yanguoyu force-pushed the feat-ckb-check branch 3 times, most recently from 01e461d to 7bf2f00 Compare August 17, 2023 11:58
@yanguoyu yanguoyu requested a review from Keith-CY August 17, 2023 12:00
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 18, 2023

/package
Packaging for test is done in 5946417713. @yanguoyu

@silySuper
Copy link
Collaborator

silySuper commented Aug 18, 2023

/package

Packaging for test is done in 5900767298. @silySuper

compatible.csv Outdated Show resolved Hide resolved
packages/neuron-wallet/src/services/node.ts Outdated Show resolved Hide resolved
@Keith-CY Keith-CY added this pull request to the merge queue Aug 24, 2023
Merged via the queue into nervosnetwork:develop with commit f7d28f2 Aug 24, 2023
10 checks passed
@yanguoyu yanguoyu deleted the feat-ckb-check branch August 25, 2023 07:58
@Keith-CY Keith-CY mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants