Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove address and script convertion from ckb-sdk-js #2801

Merged
merged 4 commits into from
Aug 24, 2023
Merged

refactor: remove address and script convertion from ckb-sdk-js #2801

merged 4 commits into from
Aug 24, 2023

Conversation

zhangyouxin
Copy link
Contributor

Description

remove scriptToAddress and addressToScript usage of ckb-sdk-js

Resolve part of: Magickbase/neuron-public-issues#201

@zhangyouxin zhangyouxin mentioned this pull request Aug 10, 2023
Closed
WhiteMinds
WhiteMinds approved these changes Aug 15, 2023
View reviewed changes
packages/neuron-wallet/src/services/cells.ts Outdated Show resolved Hide resolved
packages/neuron-wallet/src/services/transaction-sender.ts Outdated Show resolved Hide resolved
zhangyouxin and others added 2 commits August 15, 2023 15:22
@zhangyouxin @WhiteMinds
Update packages/neuron-wallet/src/services/cells.ts
7a4d09d 
Co-authored-by: WhiteMind <WhiteMind@qq.com>
@zhangyouxin @WhiteMinds
Update packages/neuron-wallet/src/services/transaction-sender.ts
734289a 
Co-authored-by: WhiteMind <WhiteMind@qq.com>
@zhangyouxin
Copy link
Contributor Author

zhangyouxin commented Aug 16, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 5874231165. @zhangyouxin

@FrederLu FrederLu requested a review from silySuper August 22, 2023 10:18
@Keith-CY Keith-CY added this pull request to the merge queue Aug 24, 2023
Merged via the queue into nervosnetwork:develop with commit 9d585fe Aug 24, 2023
@zhangyouxin zhangyouxin mentioned this pull request Aug 25, 2023
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura approved these changes

@WhiteMinds WhiteMinds WhiteMinds approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@silySuper silySuper silySuper approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

@FrederLu FrederLu Awaiting requested review from FrederLu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangyouxin @homura @WhiteMinds @yanguoyu @silySuper @Keith-CY