Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Detect new upgrade on launch #2783

Merged

Conversation

yanguoyu
Copy link
Collaborator

  1. No update both starting and checking by manual
noupdater.mov
  1. No update when starting but has update when checking by manual
hasupdaternexttime.mov
  1. Has update when starting
hasupdaterfirst.mov

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Jul 27, 2023

/package 2023-08-03 11:48
Packaging for test is done in 5746392672. @yanguoyu

@yanguoyu
Copy link
Collaborator Author

https://github.com/nervosnetwork/neuron/actions/runs/5687806837 @silySuper for case 2

@silySuper
Copy link
Collaborator

silySuper commented Jul 28, 2023

1.Verified,pass
2.Does no update when starting but has update when checking by manual should revert to the previous state, which is to show the old version when cancel update in midway @Danie0918

@Danie0918
Copy link
Collaborator

2.Does no update when starting but has update when checking by manual should revert to the previous state, which is to show the old version when cancel update in midway @Danie0918

In this case, if a new version is fetched, the new version should be displayed.

@silySuper
Copy link
Collaborator

Bugs link: Magickbase/neuron-public-issues#251
After fix and confirm these bugs I will approve this issue~

@yanguoyu yanguoyu force-pushed the detect-new-upgrade-on-launch branch from e127824 to f9f75ac Compare July 31, 2023 12:21
@yanguoyu
Copy link
Collaborator Author

Bugs link: Magickbase/neuron-public-issues#251 After fix and confirm these bugs I will approve this issue~

The bug has fixed and package again, you can get the packages from the PR comment.

@yanguoyu yanguoyu force-pushed the detect-new-upgrade-on-launch branch 2 times, most recently from 36d67ee to bbb6636 Compare August 1, 2023 23:25
@yanguoyu yanguoyu force-pushed the detect-new-upgrade-on-launch branch from bbb6636 to 9c2e70c Compare August 1, 2023 23:27
@FrederLu
Copy link
Collaborator

FrederLu commented Aug 2, 2023

/package
Packaging for test is done in 5734157575. @FrederLu

@yanguoyu yanguoyu force-pushed the detect-new-upgrade-on-launch branch from 9173c37 to d0f3890 Compare August 2, 2023 06:02
@yanguoyu yanguoyu added this pull request to the merge queue Aug 4, 2023
Merged via the queue into nervosnetwork:develop with commit 34fff73 Aug 4, 2023
10 checks passed
@yanguoyu yanguoyu deleted the detect-new-upgrade-on-launch branch August 4, 2023 09:35
@Keith-CY Keith-CY mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants