Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade lumos to the 0.20.x #2683

Merged
merged 25 commits into from
Jun 21, 2023

Conversation

homura
Copy link
Collaborator

@homura homura commented May 25, 2023

This PR resolve Magickbase/neuron-public-issues#140

  • upgrading lumos to 0.20.x
  • replace @nervina-labs/ckb-indexer with @ckb-lumos/ckb-indexer

homura added 5 commits May 24, 2023 22:23
# Conflicts:
#	package.json
#	packages/neuron-wallet/.eslintrc.js
#	packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
#	packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts
#	packages/neuron-wallet/src/services/multisig.ts
#	packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts
#	packages/neuron-wallet/tests/block-sync-renderer/indexer-connector.test.ts
#	packages/neuron-wallet/tests/services/multisig.test.ts
#	packages/neuron-wallet/tests/services/tx/transaction-generator.test.ts
#	yarn.lock
@Keith-CY
Copy link
Collaborator

I've invited @homura @IronLu233 and @zhangyouxin to this repo so we can assign you as reviewers

@github-actions
Copy link
Contributor

Packaging for test is done in 5266132006 for commit a1dae5f .

@FrederLu
Copy link
Collaborator

Packaging for test is done in 5266132006 for commit a1dae5f .

The problem of synchronizing this package yesterday still exists, please confirm.

@github-actions
Copy link
Contributor

Packaging for test is done in 5307504082 for commit 4fa16da .

@github-actions
Copy link
Contributor

Packaging for test is done in 5308212410 for commit 19342a9 .

@homura
Copy link
Collaborator Author

homura commented Jun 19, 2023

Packaging for test is done in 5308212410 for commit 19342a9 .

@FrederLu Can you help to verify this package again?

@FrederLu
Copy link
Collaborator

Packaging for test is done in 5308212410 for commit 19342a9 .

@FrederLu Can you help to verify this package again?

Known issues still exist.

@github-actions
Copy link
Contributor

Packaging for test is done in 5322859411 for commit fa8e5f7 .

@yanguoyu
Copy link
Collaborator

Packaging for test is done in 5308212410 for commit 19342a9 .

@FrederLu Can you help to verify this package again?

Known issues still exist.

Is it caused by #2732? You can delete all of your multisig configs and only add a multisig address to verify it.

@FrederLu
Copy link
Collaborator

Packaging for test is done in 5308212410 for commit 19342a9 .

@FrederLu Can you help to verify this package again?

Known issues still exist.

Is it caused by #2732? You can delete all of your multisig configs and only add a multisig address to verify it.

The duplicate multi-signature information has been deleted during the previous verification, but it still seems to be out of sync. Check again today with the new package.

@github-actions
Copy link
Contributor

Packaging for test is done in 5330605946 for commit 3d7a766 .

@homura
Copy link
Collaborator Author

homura commented Jun 21, 2023

@FrederLu I'm so sorry to make you verify this PR again and again, I've merged with the latest code and verified it locally again

Screen.Recording.2023-06-21.at.14.26.53.mov

@FrederLu
Copy link
Collaborator

FrederLu commented Jun 21, 2023

Packaging for test is done in 5330605946 for commit 3d7a766 .

Create a new multi-signature address and transfer money up, and then use this multi-signature to transfer money to other addresses, prompting that the balance is insufficient;
At the same time, after the cache is cleared, the multi-signatures that have balances before show 0, and the synchronization is abnormal.

cells.zip
neuron_debug_1687335555659.zip
multisig-config_1687335748765.json.zip

@yanguoyu
Copy link
Collaborator

Packaging for test is done in 5330605946 for commit 3d7a766 .

Create a new multi-signature address and transfer money up, and then use this multi-signature to transfer money to other addresses, prompting that the balance is insufficient; At the same time, after the cache is cleared, the multi-signatures that have balances before show 0, and the synchronization is abnormal.

cells.zip neuron_debug_1687335555659.zip multisig-config_1687335748765.json.zip

image From your cell.SQLite, you have the same multisig config in the different wallets. https://github.com//pull/2732

@FrederLu
Copy link
Collaborator

Packaging for test is done in 5330605946 for commit 3d7a766 .

Create a new multi-signature address and transfer money up, and then use this multi-signature to transfer money to other addresses, prompting that the balance is insufficient; At the same time, after the cache is cleared, the multi-signatures that have balances before show 0, and the synchronization is abnormal.
cells.zip neuron_debug_1687335555659.zip multisig-config_1687335748765.json.zip

image From your cell.SQLite, you have the same multisig config in the different wallets. https://github.com/[/pull/2732](https://github.com/nervosnetwork/neuron/pull/2732)

Well, I deleted it before, and I forgot to delete it after adding and using it when verifying other PRs later.
Synchronization is now normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace neuron/packages/ckb-indexer with lumos/ckb-indexer
7 participants