-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade lumos to the 0.20.x #2683
Conversation
# Conflicts: # package.json # packages/neuron-wallet/.eslintrc.js # packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts # packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts # packages/neuron-wallet/src/services/multisig.ts # packages/neuron-wallet/tests/block-sync-renderer/indexer-cache-service.intg.test.ts # packages/neuron-wallet/tests/block-sync-renderer/indexer-connector.test.ts # packages/neuron-wallet/tests/services/multisig.test.ts # packages/neuron-wallet/tests/services/tx/transaction-generator.test.ts # yarn.lock
I've invited @homura @IronLu233 and @zhangyouxin to this repo so we can assign you as reviewers |
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts
Show resolved
Hide resolved
# Conflicts: # packages/neuron-wallet/package.json # packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts # packages/neuron-wallet/src/services/rpc-service.ts # packages/neuron-wallet/tests/block-sync-renderer/indexer-connector.test.ts # yarn.lock
Packaging for test is done in 5266132006 for commit a1dae5f . |
The problem of synchronizing this package yesterday still exists, please confirm. |
packages/neuron-wallet/src/database/chain/entities/multisig-output.ts
Outdated
Show resolved
Hide resolved
Packaging for test is done in 5307504082 for commit 4fa16da . |
Packaging for test is done in 5308212410 for commit 19342a9 . |
@FrederLu Can you help to verify this package again? |
Known issues still exist. |
Packaging for test is done in 5322859411 for commit fa8e5f7 . |
Is it caused by #2732? You can delete all of your multisig configs and only add a multisig address to verify it. |
The duplicate multi-signature information has been deleted during the previous verification, but it still seems to be out of sync. Check again today with the new package. |
Packaging for test is done in 5330605946 for commit 3d7a766 . |
@FrederLu I'm so sorry to make you verify this PR again and again, I've merged with the latest code and verified it locally again Screen.Recording.2023-06-21.at.14.26.53.mov |
Create a new multi-signature address and transfer money up, and then use this multi-signature to transfer money to other addresses, prompting that the balance is insufficient; cells.zip |
![]() |
Well, I deleted it before, and I forgot to delete it after adding and using it when verifying other PRs later. |
This PR resolve Magickbase/neuron-public-issues#140
@nervina-labs/ckb-indexer
with@ckb-lumos/ckb-indexer