Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'contact us' in the menu -> help submenu #2454

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented Jul 18, 2022

This PR adds an extra contact method via mail for users who
are not programmers and don't know GitHub.

A sub-menu named 'Contact Us' is added in "Menu -> Help" that
invokes a local mail client to send help request to
"neuron@magickbase.com"

image
image
image
image

Ref: Magickbase/neuron-public-issues#30

This PR adds an extra contact method via mail for users who
are not programmers and don't know GitHub.

A sub-menu named 'Contact Us' is added in "Menu -> Help" that
invokes a local mail client to send help request to
"neuron@magickbase.com"
@Cedar67
Copy link
Contributor

Cedar67 commented Jul 18, 2022

When the system email client program cannot be found, the popup window cannot be closed by click OK button.

image

@Cedar67
Copy link
Contributor

Cedar67 commented Jul 18, 2022

The pop-up message does not display Chinese characters.

image

@Keith-CY
Copy link
Collaborator Author

When the system email client program cannot be found, the popup window cannot be closed by click OK button.

image

Cool, I think an extra button to copy our email could be added in the dialog, I'll update it tomorrow

@Cedar67
Copy link
Contributor

Cedar67 commented Jul 19, 2022

When clicking Contact Us on a system with a mail client, the browser window pops up instead of opening the expected mail delivery template.

20220719-105049-HD.mov

@Keith-CY
Copy link
Collaborator Author

When the system email client program cannot be found, the popup window cannot be closed by click OK button.
image

Cool, I think an extra button to copy our email could be added in the dialog, I'll update it tomorrow

Copy mail address was added by 4485569
image

@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Jul 19, 2022

When clicking Contact Us on a system with a mail client, the browser window pops up instead of opening the expected mail delivery template.

20220719-105049-HD.mov

The browser was set as the default application for handling an mail by operating system, I think there's no good way to check if it's a valid mail client, do you have any idea @yanguoyu

@Keith-CY Keith-CY requested a review from yanguoyu July 19, 2022 06:33
@yanguoyu
Copy link
Collaborator

When clicking Contact Us on a system with a mail client, the browser window pops up instead of opening the expected mail delivery template.
20220719-105049-HD.mov

The browser was set as the default application for handling an mail by operating system, I think there's no good way to check if it's a valid mail client, do you have any idea @yanguoyu

I think there's no more solution if users don't install an email app.
Providing our email address also resolves some problems. Maybe we should change the tips to Please copy the email address then send an email to us?

@Keith-CY
Copy link
Collaborator Author

When clicking Contact Us on a system with a mail client, the browser window pops up instead of opening the expected mail delivery template.
20220719-105049-HD.mov

The browser was set as the default application for handling an mail by operating system, I think there's no good way to check if it's a valid mail client, do you have any idea @yanguoyu

I think there's no more solution if users don't install an email app. Providing our email address also resolves some problems. Maybe we should change the tips to Please copy the email address then send an email to us?

image
Message was updated to include the text appended in the mail template.

Copy link
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants