Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multisig import and export config compatible with ckb-cli #2442

Merged

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Jul 6, 2022

Multisig config created by ckb-cli can also import by Neuron.

adapt-ckb-cli.mov

@yanguoyu yanguoyu force-pushed the feat-compatible-multisig-ckbcli branch from bf56388 to 8603fb7 Compare July 15, 2022 04:23
Copy link
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Import the multisig address file generated by the CKB CLI for the first time.
✅ Import the multisig address file generated by the CKB CLI repeatedly.
✅ Import a [1 of 2] multisig address file generated by the CKB CLI.
✅ Import a [2 of 2] multisig address file generated by the CKB CLI.
✅ View the multisig address file generated by CKB CLI in Neuron.
✅ Export the multisig address file generated by the CKB CLI.
✅ Transation is performed by Neuron through the multisig address generated by CKB CLI.
✅ Approvement is performed by Neuron through the multisig address generated by CKB CLI.

@Keith-CY Keith-CY merged commit 9b9287a into nervosnetwork:develop Jul 18, 2022
@yanguoyu yanguoyu deleted the feat-compatible-multisig-ckbcli branch July 18, 2022 02:39
@Keith-CY Keith-CY mentioned this pull request Sep 2, 2022
@Keith-CY Keith-CY mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants