This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
feat: add common_ref argument for keypair tool #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
approved these changes
Feb 9, 2020
nolanxyg
approved these changes
Feb 9, 2020
yejiayu
approved these changes
Feb 9, 2020
zeroqn
pushed a commit
to zeroqn/muta
that referenced
this pull request
Feb 11, 2020
* feat: add common_ref arg for keypair tool * new line
zeroqn
pushed a commit
to zeroqn/muta
that referenced
this pull request
Feb 11, 2020
* feat: add common_ref arg for keypair tool * new line
cryptowen
pushed a commit
that referenced
this pull request
Feb 12, 2020
* bench excute (#145) * fix(makefile): Docker push to the correct image (#146) * feat: Update juniper, supports async (#149) * feat: Update juniper * fix ci * fix ci * fix(network): give up retry (#152) * change(network): only tag unconnectable for io::ErrorKind::Other * fix(network): never reconnect later * fix(network): clippy warning * flush mempool after storage (#155) * feat: add common_ref argument for keypair tool (#154) * feat: add common_ref arg for keypair tool * new line * feat: add panic hook to logger (#156) * feat: add panic hook to logger * chore: change crate location * filter callback_cache while pull txs (#158) * change(network): output more info for debug rpc timeout (#157) * feat(network): output peer connected addr on RPC error * change(network): also output number of connected peers * change(network): remove rpc entry after timeout * doc(network): comment about expect() on Option session public key * change(network): output more info on rpc entry not found * feat: update overlord with brake engine (#159) * feat(consensus): update overlord with brake engine * chore: update overlord version * feat: register choke handler in p2p * update overlord tmp * feat(consensus): update overlord with brake engine * chore: update overlord version * feat: register choke handler in p2p * update overlord tmp update overlord update overlord update overlord update overlord * update overlord update overlord * fix(sync): Save the latest height when an error occurred * fix(sync): Check remote block * chore: Add log for check block * chore: print order hashes length * feat: add panic hook to logger (#156) * feat: add panic hook to logger * chore: change crate location * refactor: Remove boradcast when start sync * fix: empty cycle used in genesis block * filter callback_cache while pull txs (#158) * chore: update overlord * fix CI Co-authored-by: Jiayu Ye <yejiayu.fe@gmail.com> Co-authored-by: Wenchao Hu <me@huwenchao.com> Co-authored-by: rev-chaos <wancencen@cryptape.com> * fix(doc): fix graphql_api doc link and doc-api build sh (#161) * fix(metadata): test broken after consensus update Co-authored-by: rev-chaos <wancencen@cryptape.com> Co-authored-by: Jiayu Ye <yejiayu.fe@gmail.com> Co-authored-by: Wenchao Hu <me@huwenchao.com> Co-authored-by: Eason Gao <kaoimin@qq.com> Co-authored-by: LycrusHamster <liang2929@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
add common_ref argument for keypair tool.
What this PR does / why we need it:
When we use the chain in production, validators will generate private keys separately, but they need the same common_ref. Add this argument to pass a pre-agreed common_ref to generate bls public keys.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: