Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner link to old docs #38

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Banner link to old docs #38

merged 3 commits into from
Jul 2, 2020

Conversation

ashchan
Copy link
Contributor

@ashchan ashchan commented Jul 2, 2020

Note: the legacy site url is configured as https://docs-old.nervos.org which is NOT accessible ATM. Should it require update/change we can simple change oldDocSiteUrl from siteConfig.js.

The banner HTML is put inside Footer.js, which is the only point we can customize (docusaurus v1.x). HTML element placed there is difficult to position at our need, so I added an extra.js which moves the banner to top on page load.

PC

Screen Shot 2020-07-02 at 12 27 02

Mobile

Screen Shot 2020-07-02 at 12 26 34

@ashchan ashchan requested a review from xxuejie July 2, 2020 03:33
@xxuejie xxuejie merged commit 2a7fe70 into develop Jul 2, 2020
@xxuejie xxuejie deleted the banner-link-to-old-docs branch July 2, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants