Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add include_tx_pool: Option<bool> param to ChainRpcImpl::get_live_cell' #4454

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Add include_tx_pool: Option<bool> param to ChainRpcImpl::get_live_cell' #4454

merged 2 commits into from
Jun 7, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • Add include_tx_pool: bool param to ChainRpcImpl::get_live_cell RPC

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/get_live_cell_include_tx_pool branch 2 times, most recently from e8b588d to bb67755 Compare May 11, 2024 01:29
@eval-exec eval-exec marked this pull request as ready for review May 11, 2024 01:38
@eval-exec eval-exec requested a review from a team as a code owner May 11, 2024 01:38
@eval-exec eval-exec requested review from doitian, quake, chenyukang and zhangsoledad and removed request for a team May 11, 2024 01:38
@eval-exec eval-exec added the b:rpc Break RPC interface label May 11, 2024
@eval-exec eval-exec changed the title Add include_tx_pool: bool param to ChainRpcImpl::get_live_cell' Add include_tx_pool: Option<bool> param to ChainRpcImpl::get_live_cell' May 11, 2024
@eval-exec eval-exec marked this pull request as draft May 11, 2024 02:44
@eval-exec eval-exec force-pushed the exec/get_live_cell_include_tx_pool branch from bb67755 to 7a9af4b Compare May 11, 2024 05:01
@eval-exec eval-exec marked this pull request as ready for review May 11, 2024 05:01
@quake quake merged commit 5872af1 into nervosnetwork:develop Jun 7, 2024
32 checks passed
@doitian
Copy link
Member

doitian commented Jun 11, 2024

@eval-exec please backport to rc/v0.117.x

@eval-exec eval-exec mentioned this pull request Jun 11, 2024
Merged
doitian added a commit that referenced this pull request Jun 11, 2024
@doitian
Merge pull request #4479 from eval-exec/backport/4454
cd6e378 
Backport #4454 Add `include_tx_pool: Option<bool>` param to `ChainRpcImpl::get_live_cell`'
@eval-exec eval-exec mentioned this pull request Jun 24, 2024
Merged
@eval-exec eval-exec deleted the exec/get_live_cell_include_tx_pool branch June 25, 2024 01:19
@quake quake mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang left review comments

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
b:rpc Break RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eval-exec @doitian @quake @chenyukang