Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpc doc generator issues #4360

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

There are several issues:

  • Uint32 is wrong and replaced with AlertId
  • Missing some fields, such as IndexerSearchKeyFilter, cc @EthanYuan

What is changed and how it works?

What's Changed:

  • Fix issues in gen.rs
  • Add some predefined types in the doc generator, similar with rpc.py

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner February 21, 2024 04:00
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team February 21, 2024 04:00
@chenyukang chenyukang force-pushed the yukang-fix-doc-issue branch 2 times, most recently from 5a9644e to d2fdfc3 Compare February 22, 2024 05:01
@chenyukang chenyukang changed the title WIP: Fix rpc doc generator issues Fix rpc doc generator issues Feb 23, 2024
@chenyukang chenyukang force-pushed the yukang-fix-doc-issue branch 2 times, most recently from fd968cd to 16f7e81 Compare February 26, 2024 03:30
@chenyukang chenyukang enabled auto-merge February 26, 2024 03:31
@chenyukang chenyukang added this pull request to the merge queue Feb 26, 2024
Merged via the queue into nervosnetwork:develop with commit 0e1e2b1 Feb 26, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants