feat: bundle app config #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write to temp file first, then move to the target location.
Merged
doitian
added a commit
that referenced
this pull request
Apr 22, 2019
🎉[ᚬmaster] Rc/v0.9.0 ### Bug Fixes * #410: network panic errors r=jjyr a=jjyr * Peer Store no such table * get peer index panic * #386: flatbuffers vtable `num_fields` overflow r=zhangsoledad a=doitian Refs nervosnetwork/cfb#16 * #385: Upgrade p2p fix repeat connection bug r=jjyr a=TheWaWaR Related PR: nervosnetwork/tentacle#92 * #382: reset peer store connection status when setup r=TheWaWaR a=jjyr 1. reset peer status 2. remove banned addrs from peer_attemps result * #424: many bug fixes of the p2p network issues fix a=TheWaWaR,zhangsoledad ### Features * #491: update lock cell for segwit and address format a=classicalliu * #368: segregated witness r=janx,quake a=zhangsoledad * #409: remove uncle cellbase r=doitian a=zhangsoledad * #369: Embed testnet chain spec in compiled binary r=doitian a=xxuejie * #344: Revise script structure r=xxuejie a=xxuejie * #425: Bundle app config in compiled binary a=doitian ### Improvements * #392: avoid recursive lock a=zhangsoledad ### BREAKING CHANGES This release has changed core data structure, please delete the old data directory. The testnet chain spec is also changed, which is incompatible with previous versions. Command line argument `-c` is removed, and a new command line argument `-C` is added. See `ckb help` for details. Now the command `ckb` no longer searches the config file `nodes/default.toml`. It looks for the config file `ckb.toml` or `ckb-miner.toml` in current directory and uses the default config options when not found. A new command `ckb init` is added, see its usage with `ckb init --help`. Config file `ckb.toml` changes: - Removed `logger.file`, `db.path` and `network.path` from config file. - Added config option `logger.log_to_stdout` and `logger.log_to_file`. - Section `block_assembler` now accepts two options `binary_hash` and `args`. - Added a new option to set sentry DSN. File `miner.toml` changes: - Option `spec` is moved under `chain`, which is consistent with `ckb.toml`. - Move miner own config options under section `miner`. - Remove `logger.file` from config file. - Add config option `logger.log_to_stdout` and `logger.log_to_file`. It is recommended to export the config files via `ckb init`, then apply the modifications upon the new config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: [PREVIEW]
ckb_resource::ResourceLocatorto load config files, which fallbacks to the bundled files.ckb initto dump the bundled config files.src.logger.file,db.pathandnetwork.pathare set automatically from the data dir.Breaking Changes:
-c, and add command line argument-C.nodes/default.toml.logger.file,db.pathandnetwork.pathfrom config file. Add config optionlogger.copy_to_stdout.Future Enhancements:
TODO
ckb init.ckb initshould quit if any file already exists unless--forceis specified.ckb initshould write file to temp file first, and move to the target location to avoid generating partial file because of interrupts.