Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc(ChainRpc): Add only_committed param for get_transaction #3963

Merged
merged 2 commits into from
May 4, 2023
Merged

rpc(ChainRpc): Add only_committed param for get_transaction #3963

merged 2 commits into from
May 4, 2023

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #3962
What's Changed:

Related changes

  • Add only_committed param for get_transaction RPC.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Apr 27, 2023
@eval-exec eval-exec force-pushed the exec/get_transaction-only_committed branch 3 times, most recently from 319640d to 3d7539b Compare May 3, 2023 11:29
@eval-exec eval-exec force-pushed the exec/get_transaction-only_committed branch from 3d7539b to 4145095 Compare May 3, 2023 11:33
@eval-exec eval-exec marked this pull request as ready for review May 3, 2023 11:34
@eval-exec eval-exec requested a review from a team as a code owner May 3, 2023 11:34
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team May 3, 2023 11:34
@eval-exec eval-exec self-assigned this May 3, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue May 4, 2023
Merged via the queue into nervosnetwork:develop with commit f6aeb2c May 4, 2023
@doitian doitian mentioned this pull request Jun 13, 2023
Closed
This was referenced Nov 23, 2023
Merged
Merged
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees

@eval-exec eval-exec

Labels
t:enhancement Type: Feature, refactoring.
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce an rpc to query only confirmed transactions
2 participants
@eval-exec @zhangsoledad