light client softfork #3515
Merged
light client softfork #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/light-client-softfork
branch
from
9959e53 to
0ccd974
Compare
zhangsoledad
force-pushed
the
zhangsoledad/light-client-softfork
branch
7 times, most recently
from
3a39cdf to
79276d1
Compare
zhangsoledad
requested review from
quake and
yangby-cryptape
and removed request for
a team
zhangsoledad
force-pushed
the
zhangsoledad/light-client-softfork
branch
from
456ff7c to
2127104
Compare
yangby-cryptape
approved these changes
Aug 4, 2022
quake
reviewed
Aug 8, 2022
zhangsoledad
force-pushed
the
zhangsoledad/light-client-softfork
branch
2 times, most recently
from
7cc35d2 to
080f2fb
Compare
zhangsoledad
force-pushed
the
zhangsoledad/light-client-softfork
branch
from
080f2fb to
57f4ac2
Compare
quake
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Implement versionbits softfork activation, active softfork through versionbits.
Simple refactoring of the chain module, and integration of the chain_root checks into the extension verifier.
https://github.com/nervosnetwork/ckb/blob/79276d1596144997268511e1c23ae0ec996a840b/chain/src/chain.rs
https://github.com/nervosnetwork/ckb/pull/3515/files#diff-a8674a1e55ab7cf3a12a62c1ab80fe90bacfaea59aeca6d0f3c839aa7a565410R516-R594
Some parameters are now hardcode, and can be adjusted later
https://github.com/nervosnetwork/ckb/pull/3515/files#diff-7aabb1d939a59b6c50c0eef8278852539bc3f54284e583aa784c8c3fc554b567R510-R537
Check List
Tests
Release note