Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): tail failed logs #1474

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Conversation

keroro520
Copy link
Contributor

  • feat(test): Tail nodes' logs when fails

    We treat tests are failed when

    • tests panicked
    • any thread in nodes has panicked(via searching nodes' logs)
  • chore(test): Refactor Net and Node

@keroro520 keroro520 requested a review from a team August 26, 2019 03:29
@nervos-bot
Copy link

nervos-bot bot commented Aug 26, 2019

@driftluo is assigned as the chief reviewer

@keroro520 keroro520 requested a review from quake August 26, 2019 03:29
@u2
Copy link
Contributor

u2 commented Aug 27, 2019

bors r=doitian,u2

@bors
Copy link
Contributor

bors bot commented Aug 27, 2019

👊

@u2
Copy link
Contributor

u2 commented Aug 27, 2019

bors r=doitian,u2

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Aug 27, 2019
bors bot added a commit that referenced this pull request Aug 27, 2019
1474: feat(test): tail failed logs r=doitian,u2 a=keroro520

* feat(test): Tail nodes' logs when fails

  We treat tests are failed when

  - tests panicked
  - any thread in nodes has panicked(via searching nodes' logs)

* chore(test): Refactor Net and Node

Co-authored-by: keroro520 <keroroxx520@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 27, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 046aae9 into nervosnetwork:develop Aug 27, 2019
bors bot added a commit that referenced this pull request Oct 9, 2019
1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520

The number of logs is acceptable after #1474. 

Co-authored-by: keroro520 <keroroxx520@gmail.com>
bors bot added a commit that referenced this pull request Oct 10, 2019
1664: chore: update get_block_template rpc doc r=quake,u2,keroro520,yangby-cryptape a=shaojunda

replace difficulty with compact_target

1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520

The number of logs is acceptable after #1474. 

1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo

Disconnect check by all part

1673: docs: Update PoW mining algorithm description r=u2,quake a=ashchan

Now that this has been decided the doc should reflect that before the next round of mining test.

1680: fix: get_block_transactions_process r=u2,quake a=zhangsoledad



1689: chore: issuance comment r=u2,quake a=zhangsoledad

comments were lost on rebase

1690: ci: Make sure cargo-audit up-to-date r=quake,u2 a=zhangsoledad

rustsec/rustsec#143
https://internals.rust-lang.org/t/idea-cargo-install-update/11072
rust-lang/cargo#6797



1691: chore: speed up maturity test r=u2,quake a=zhangsoledad



Co-authored-by: shaojunda <shaojunda@gmail.com>
Co-authored-by: keroro520 <keroroxx520@gmail.com>
Co-authored-by: driftluo <driftluo@foxmail.com>
Co-authored-by: James Chen <james@ashchan.com>
Co-authored-by: zhangsoledad <787953403@qq.com>
bors bot added a commit that referenced this pull request Oct 10, 2019
1664: chore: update get_block_template rpc doc r=quake,u2,keroro520,yangby-cryptape a=shaojunda

replace difficulty with compact_target

1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520

The number of logs is acceptable after #1474. 

1671: test: disconnect check by all part r=u2,keroro520,quake a=driftluo

Disconnect check by all part

1673: docs: Update PoW mining algorithm description r=u2,quake a=ashchan

Now that this has been decided the doc should reflect that before the next round of mining test.

Co-authored-by: shaojunda <shaojunda@gmail.com>
Co-authored-by: keroro520 <keroroxx520@gmail.com>
Co-authored-by: driftluo <driftluo@foxmail.com>
Co-authored-by: James Chen <james@ashchan.com>
bors bot added a commit that referenced this pull request Oct 10, 2019
1664: chore: update get_block_template rpc doc r=quake,u2,keroro520,yangby-cryptape a=shaojunda

replace difficulty with compact_target

1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520

The number of logs is acceptable after #1474. 

Co-authored-by: shaojunda <shaojunda@gmail.com>
Co-authored-by: keroro520 <keroroxx520@gmail.com>
bors bot added a commit that referenced this pull request Oct 10, 2019
1669: chore(test): Allow CI debug logs r=u2,zhangsoledad a=keroro520

The number of logs is acceptable after #1474. 

Co-authored-by: keroro520 <keroroxx520@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:ready-to-merge Status: Waiting to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants