feat: add with_hash to transaction to_h #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaojunda
force-pushed
the
shaojunda-use-strict-on-rpc
branch
from
9a22acd to
55abb63
Compare
ashchan
reviewed
Sep 18, 2019
lib/ckb/types/transaction.rb
Outdated
| @@ -62,7 +62,7 @@ def sign(key, tx_hash) | |||
| ) | |||
| end | |||
|
|
|||
| def to_h | |||
| def to_h(with_hash = true) | |||
There was a problem hiding this comment.
A boolean param is not good here - what if we want to exclude another property? Then we'd have to_h(with_hash = true, with_xxx = true).
I suggest we keep all properties in the model, but strip (exclude) the txhash when calling rpc.
There was a problem hiding this comment.
Thanks, it make sense, I will fix this.
ashchan
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cryptape/ckb-explorer-internal/issues/251