Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Address format implementation #13

Merged
merged 5 commits into from
Apr 10, 2019
Merged

feat: Address format implementation #13

merged 5 commits into from
Apr 10, 2019

Conversation

xxuejie
Copy link
Contributor

@xxuejie xxuejie commented Apr 3, 2019

No description provided.

@xxuejie xxuejie requested review from ashchan and classicalliu April 3, 2019 06:30
@ashchan
Copy link
Contributor

ashchan commented Apr 3, 2019

@classicalliu Could you please add some test cases that other SDKs can follow and confirm?

@classicalliu
Copy link
Contributor

@classicalliu Could you please add some test cases that other SDKs can follow and confirm?

I'll check and work on it

@classicalliu
Copy link
Contributor

@ashchan tests added

@ashchan
Copy link
Contributor

ashchan commented Apr 4, 2019

@ashchan tests added

Great. Looks good.

@classicalliu classicalliu requested review from ashchan and removed request for classicalliu April 4, 2019 07:59
@ashchan
Copy link
Contributor

ashchan commented Apr 9, 2019 •
edited
Loading

@classicalliu We have some conflicts. Update: resolved.

@ashchan ashchan merged commit e773a24 into develop Apr 10, 2019
@ashchan ashchan deleted the address-format-implementation branch April 10, 2019 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashchan ashchan ashchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxuejie @ashchan @classicalliu