feat: wasm support for browser #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update database impl update takewhile benchmark update basic operations adapt light-client-lib with sync storage update debug misc stuff update new tests
|
CCC fix released in ckb-devrel/ccc#93 |
|
(Mis-clicked to close, please ignore that) |
ckb-devrel/ccc#92 is the fix, and ckb-devrel/ccc#93 is the release of the fix. The fix was included in the changelog. |
I found it just now, thank you! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
yangby-cryptape
previously approved these changes
Jan 17, 2025
quake
reviewed
Jan 17, 2025
yangby-cryptape
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running light client in browser, including the following major changes:
light-clientintolight-client-lib,light-client-bin, andlight-client-wasmlight-client-db-workerto provide sync API access for IndexedDBlight-client-jsas a JS API wrapper for frontend developers, with type definition from@ckb-ccc/coreand similar APIs like RPC clientlight-client-wasm,light-client-db-workerandlight-client-js, making them easy to be published to registries like npmThings need to be done:
Waiting for a bug in@ckb-ccc/corefix:hexFromin@ckb-ccc/core/barrelnot producing valid hex strings when an empty array is provided ckb-devrel/ccc#90 to be fixedMost types we used from@ckb-ccc/coreare not exposed by default. Need more communication with devrel to discuss if these should be exposedIntegrated tests and unit-testsnpm package: https://www.npmjs.com/package/ckb-light-client-js