Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cache for market data #2426

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Feb 7, 2025

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid February 7, 2025 04:45
@rabbitz rabbitz added this pull request to the merge queue Feb 7, 2025
Merged via the queue into nervosnetwork:develop with commit 20b9531 Feb 7, 2025
1 check passed
@rabbitz rabbitz deleted the fix/market_data branch February 7, 2025 05:01
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (f373f6b) to head (de5820b).
Report is 598 commits behind head on develop.

Files with missing lines Patch % Lines
app/controllers/api/v1/market_data_controller.rb 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (54.79%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (de5820b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (de5820b)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2426       +/-   ##
============================================
- Coverage    67.56%   54.79%   -12.77%     
============================================
  Files          289      378       +89     
  Lines         7944    10869     +2925     
============================================
+ Hits          5367     5956      +589     
- Misses        2577     4913     +2336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants