Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 740 #2047

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Issue 740 #2047

merged 6 commits into from
Jul 15, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid requested a review from rabbitz July 12, 2024 09:18
@zmcNotafraid zmcNotafraid marked this pull request as ready for review July 12, 2024 09:18
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.56%. Comparing base (f373f6b) to head (d682817).
Report is 334 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (d682817). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (d682817)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2047      +/-   ##
===========================================
- Coverage    67.56%   62.56%   -5.01%     
===========================================
  Files          289      348      +59     
  Lines         7944     9741    +1797     
===========================================
+ Hits          5367     6094     +727     
- Misses        2577     3647    +1070     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jul 15, 2024
Merged via the queue into nervosnetwork:develop with commit 580100f Jul 15, 2024
2 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the issue-740 branch July 15, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants