Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce temperature not working #240

Closed
nickdos opened this issue Apr 10, 2021 · 6 comments
Closed

Reduce temperature not working #240

nickdos opened this issue Apr 10, 2021 · 6 comments
Labels
bug Something isn't working released

Comments

@nickdos
Copy link

nickdos commented Apr 10, 2021

Using compact mode where the temperature actions are - and +, increasing the temperature works as expected but reducing the temperature does not work - temp stays the same. I have decimals: 0.

Using the normal climate controls works as expected, so issue is with this plugin.

@nervetattoo
Copy link
Owner

Make sure to clear your browser cache.
Also, always paste your config and preferably a screenshot.
If you can open your browsers devtools console before triggering the bug, and then look for any errors (red text) there it will be helpful.

To be clear; Reducing temperature works just fine for a lot of other people, myself included so it needs more details on what might be causing the issue in your setup.

@nervetattoo nervetattoo added question Further information is requested invalid This doesn't seem right labels Apr 10, 2021
@nickdos
Copy link
Author

nickdos commented Apr 11, 2021

Tried multiple browsers and clearing cache and still see this error.

Here's my config:

control:
  _headings: false
  fan: true
  hvac:
    dry: false
    fan_only:
      name: fan
    heat_cool:
      name: auto
decimals: 0
entity: climate.daikin_ac
hide:
  temperature: true
  state: true
sensors:
  - entity: sensor.dining_room_esp_temperature
    name: Dining
  - entity: sensor.living_room_temperature
    name: Living
type: 'custom:simple-thermostat'
layout:
  mode:
    headings: false
  step: row

No JS errors or warnings in console either.

Behaviour I see is:

  • increase -> click + and temperature value goes from black text 20° to red text 21° and then a second or two later, changes back to black text as 21°.
  • decrease -> click - and temperature values stays the same (20°) but font colour changes black to red. Then a few seconds later changes back to black colour.

Updated to v.2.2.2 and HACS forced a reload of front end, but still see the same issue.

@nickdos
Copy link
Author

nickdos commented Apr 11, 2021

Found the issue. I was using decimals: 0 but did not set a value for step_size and thus got the default value of 0.5.

Adding: step_size: 1 fixed the issue.

This appears to be a regression bug as the previous version allowed the equivalent combination of settings to work as expected. Code should probably check for the mismatched combination and "do the expected thing" of using a step_size that is appropriate for the corresponding decimals value.

@nervetattoo
Copy link
Owner

Thanks for catching the bug. I can reproduce with the same config.

@nervetattoo nervetattoo added bug Something isn't working and removed invalid This doesn't seem right question Further information is requested labels Apr 11, 2021
@nervetattoo
Copy link
Owner

As any fix will be too weird I will instead show a warning if you configure a card like this so you can fix it.
Screenshot 2021-04-11 at 22 19 25

@github-actions
Copy link

🎉 This issue has been resolved in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kangaroomadman pushed a commit to kangaroomadman/simple-thermostat that referenced this issue Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants