Fix org_certificate_controller :edit cannot render #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pojiro
commented
Jul 28, 2022
Comment on lines
-12
to
+14
| <input type="checkbox" name="jitp_toggle" id="jitp_toggle" checked={f.data.jitp}> | ||
| <input type="checkbox" name="jitp_toggle" id="jitp_toggle" checked={not is_nil(f.data.jitp)}> | ||
| <%= hidden_input fp, :delete, id: "jitp-delete" %> | ||
| <div hidden={!f.data.jitp} id="jitp_form"> | ||
| <div hidden={is_nil(f.data.jitp)} id="jitp_form"> |
There was a problem hiding this comment.
f.data.jitp is not boolean, is nil or struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related commit is 8be8a6f?diff=split&w=0#diff-e253447b15c2a82a129c72a07aae8d99cc3c86efed4fc04bb9c6cd859a9738ee
This bug could have been prevented with tests, so added a test.