Remove audit and logger statement from extensions request check #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of NervesHubLink would crash if an unknown messages was pushed down over the socket. Since extensions required a new message, this could fail badly on older devices and so a check was put in place to verify the Device API version NHL was reporting to know if it is safe to request extension info or not. This removes the audit log _and_ logger statement that was happening when this safe check would not pass meaning the device version was too old to request. However, this happens with _every_ socket connection and can produce incredible amount of noise. If that level of info is needed, I suggest a future change which shows the device version reported and what that means for support on the device (i.e. in the Device settings page perhaps?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of NervesHubLink would crash if an unknown messages was pushed down over the socket. Since extensions required a new message, this could fail badly on older devices and so a check was put in place to verify the Device API version NHL was reporting to know if it is safe to request extension info or not.
This removes the audit log and logger statement that was happening when this safe check would not pass meaning the device version was too old to request. However, this happens with every socket connection and can produce incredible amount of noise.
If that level of info is needed, I suggest a future change which shows the device version reported and what that means for support on the device (i.e. in the Device settings page perhaps?)