Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change health section to not show boxes for non-reported default values #1651

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

lawik
Copy link
Contributor

@lawik lawik commented Nov 20, 2024

Before:
Screenshot 2024-11-20 at 14 07 48

After:
Screenshot 2024-11-20 at 14 08 06

The CPU percentage report will be nicer-looking as it becomes a default with the extensions updates. This was just a small nuisance. Non-reported values can just not be shown as that can be intentional on the user's end.

@lawik lawik requested a review from joshk November 20, 2024 13:09
@lawik
Copy link
Contributor Author

lawik commented Nov 20, 2024

@elinol feel free to review as well, can't tag you properly :)

@elinol
Copy link
Contributor

elinol commented Nov 20, 2024

I think this is great! Was just about to start a conversation regarding exactly this, I'm doing some stuff with metrics. You have my unofficial approval and blessing

@lawik lawik force-pushed the remove-not-reported branch from bb04937 to c3a0f60 Compare November 20, 2024 13:25
Copy link
Contributor

@nshoes nshoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@lawik lawik merged commit c652716 into main Nov 20, 2024
2 checks passed
@lawik lawik deleted the remove-not-reported branch November 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants