Show current alarms on device page #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display any current alarms for device. Click on alarm to show description if provided.
|
|
nshoes
reviewed
Nov 19, 2024
jjcarstens
reviewed
Nov 19, 2024
jjcarstens
approved these changes
Nov 20, 2024
Comment on lines
+70
to
+71
| for {alarm, description} <- alarms, | ||
| do: {String.trim_leading(alarm, "Elixir."), description} |
There was a problem hiding this comment.
Suggested change
| for {alarm, description} <- alarms, | |
| do: {String.trim_leading(alarm, "Elixir."), description} | |
| for {alarm, description} <- alarms, into: %{}, | |
| do: {String.trim_leading(alarm, "Elixir."), description} |
I don't know if it matters. I originally thought these were a list, but looks like they are a map. If that's a case, then this would ensure it's placed back into a map
There was a problem hiding this comment.
Yes, the alarms comes in a map. For current use cases it's fine to pass them on as lists here.
nshoes
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display any current alarms for device.
Click on alarm to show description if provided.