Remove an extra Deployment preload during after_join
#1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshk
force-pushed
the
reduce-deployments-re-and-preloading
branch
from
72e5370 to
f6eba9d
Compare
- Preload the deployment, along with its firmware and archive, at the start of `after_join` - Preload all the required bits again in `Deployments.set_deployment` - And only use `:force` if the deployment has changed. - This approach saves 100ms during `after_join`, which is over 15% of the total time.
joshk
force-pushed
the
reduce-deployments-re-and-preloading
branch
from
f6eba9d to
52866f1
Compare
jjcarstens
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after_joinDeployments.set_deployment, and only use:forcefor the cases where the deployment id is updated.after_join, which is over 15% of the total time.