Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch insert device metrics #1613

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Batch insert device metrics #1613

merged 1 commit into from
Oct 28, 2024

Conversation

joshk
Copy link
Collaborator

@joshk joshk commented Oct 26, 2024

This decreases the metrics event processing time by half and reduces the number of Ecto queries, including no longer needing a transaction.

Screenshot 2024-10-26 at 8 12 21 PM

(the 3 and 12 relate to the number of telemetry spans)

(the 400,000 and 1,000,000 are the number of milliseconds used for processing)

This decreases the event processing time in half, and reduces the number of Ecto queries, including no longer needing to use a transaction.
@joshk joshk force-pushed the batch-insert-device-metrics branch from 5d44109 to 6beac3a Compare October 26, 2024 07:35
@joshk joshk requested review from lawik and jjcarstens October 26, 2024 07:36
Copy link
Contributor

@lawik lawik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@joshk joshk merged commit 729b03b into main Oct 28, 2024
2 checks passed
@joshk joshk deleted the batch-insert-device-metrics branch October 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants