Reintroduce missing custom metrics and metadata to device page. #1578
Conversation
|
|
Thanks for including the screenshot. I would recommend not showing custom metrics in the health section on the Device show page as it will mess with formatting. Can we keep custom metrics on the Device Metrics page only? |
|
As clarified on Slack, this restores functionality that was broken with metrics-changes. It needs to be nicer in the next iteration of the UI. But it does matter. |
|
I would prefer if we remove the "stop saving firmware metadata" bit from this part for now. That's mixing two different topics. That merge is intentional and at some point I can explain more of my thinking there. It may turn out to be unnecessary but I think it will be helpful to have. |
| # Separate metrics from health report to store in metrics table | ||
| metrics = device_status["metrics"] | ||
|
|
||
| health_report = | ||
| device_status | ||
| |> Map.delete("metrics") | ||
| |> Map.put("metadata", Map.merge(device_status["metadata"], device_meta)) |
There was a problem hiding this comment.
I'd rather this not be in this PR :)
Also stop saving firmware metadata on device health.
elinol
force-pushed
the
reintroduce-custom-metrics-and-metadata
branch
from
d291fac to
9e9f320
Compare
|
Thank you very much ✨ |
Also stop saving firmware metadata on device health.