Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container version tagging #1549

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add container version tagging #1549

merged 1 commit into from
Sep 25, 2024

Conversation

lawik
Copy link
Contributor

@lawik lawik commented Sep 25, 2024

I believe this should make new docker containers get tagged with the version.

oestrich
oestrich approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@oestrich oestrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work with this down below to do what we want? Probably can only figure out by merging 😅

https://github.com/nerves-hub/nerves_hub_web/pull/1549/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL132

@lawik
Copy link
Contributor Author

lawik commented Sep 25, 2024

For science!

@lawik lawik merged commit 90a6573 into main Sep 25, 2024
2 checks passed
@lawik lawik deleted the container-version-tagging branch September 25, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oestrich oestrich oestrich approved these changes

@joshk joshk Awaiting requested review from joshk

@jjcarstens jjcarstens Awaiting requested review from jjcarstens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawik @oestrich