-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Known devices with expired CAs can no longer connect #838
Comments
jjcarstens
added a commit
that referenced
this issue
Jul 1, 2022
Fixes #838 We were previously requiring that the signer CA to be registered even if the device certificate was already pinned, which was incorrect. This fixes that to skip the check if we're being presented with a signer CA so that validation of the device certificate can happen. If the device cert is pinned, the check will pass. If not, it will go through the normal validation flow and fail due to an expired, unregistered signer CA anyway
jjcarstens
added a commit
that referenced
this issue
Jul 1, 2022
Fixes #838 We were previously requiring that the signer CA to be registered even if the device certificate was already pinned, which was incorrect. This fixes that to skip the check if we're being presented with a signer CA so that validation of the device certificate can happen. If the device cert is pinned, the check will pass. If not, it will go through the normal validation flow and fail due to an expired, unregistered signer CA anyway
Merged
oestrich
pushed a commit
that referenced
this issue
Mar 22, 2023
Fixes #838 We were previously requiring that the signer CA to be registered even if the device certificate was already pinned, which was incorrect. This fixes that to skip the check if we're being presented with a signer CA so that validation of the device certificate can happen. If the device cert is pinned, the check will pass. If not, it will go through the normal validation flow and fail due to an expired, unregistered signer CA anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In our org we manually pin certs for each of our devices, rendering the device CA chain-of-trust essentially moot. We don't have CAs added to the org, because our understanding has been that org device CAs are only needed for trust during JITP. This has worked well for us in the past, but after an attempted upgrade to NervesHub v1.0.0, some of our devices were unable to reconnect to NervesHub due to a certificate error. The client logs:
and the device server logs:
The affected devices were provisioned with CAs that have since expired. Even though their device certs are known, they are now being rejected when attempting to connect. This seems to be related to OTP 24 and specifically to e67f4a6.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The device is able to connect despite having an expired CA.
The text was updated successfully, but these errors were encountered: