Addressed TODO in full_images_datamanager.py to return image resolution as train rays #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrj
requested changes
Jul 22, 2024
|
fixed it, thanks! |
… resolution of the image being rendered
jb-ye
force-pushed
the
full-images-training-rays-fix
branch
from
8a86b0f
to
2251ff3
Compare
kerrj
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a todo when looking at the code base and attempted to make the appropriate changes. I'm essentially returning the resolution of the image, under the assumption that all images in the batch are the same resolution. I left in the default return value of 800 * 800 in case anything doesn't work as intended. To my understanding, splatfacto is the only method that uses the
FullImageDataManager, and the functionget_train_rays_per_batch()is used for logging metrics to the terminal. This should help display a more accurate count for the "Train Rays / Sec" metric.