Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded resize_image function to support interpolation #3297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JTStephens18
Copy link

Replaced convolution operation with interpolation. Added support for downscaling using floats.

resolves #3263

@jb-ye
Copy link
Collaborator

jb-ye commented Jul 11, 2024

I am not in favor of using aliased downscaling method for training GS. See my response here: #3263 (comment)

@kerrj
Copy link
Collaborator

kerrj commented Jul 12, 2024

One option is to use torchvision's resize which has antialiasing?

@brentyi
Copy link
Collaborator

brentyi commented Jul 12, 2024

Similarly, can we just set antialias=True in torch.nn.functional.interpolate()?

@jb-ye
Copy link
Collaborator

jb-ye commented Jul 12, 2024

One option is to use torchvision's resize which has antialiasing?

I tried this before, it still doesn't bring the same PSNR results as convolution (that's why I eventually changed it to convolution). I am a little unsure if those antialiased implementation in pytorch is correct at all. For example, as noted by this paper, most existing downscaling implementation doesn't implement antialiasing properly.

@jb-ye
Copy link
Collaborator

jb-ye commented Jul 12, 2024

Similarly, can we just set antialias=True in torch.nn.functional.interpolate()?

I am curious to see results on some MipNerf360 datasets and see whether it degrades the performance by checking the the PNSR eval curve. The current choice was made based on my observation of bicycle and garden dataset.

See #2984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question Regarding Image Downscaling Method
4 participants