Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove header from moderation view in user profile #312

Merged
merged 2 commits into from
May 30, 2024
Merged

fix: remove header from moderation view in user profile #312

merged 2 commits into from
May 30, 2024

Conversation

mr-fox93
Copy link
Collaborator

@mr-fox93 mr-fox93 commented May 16, 2024 •
edited
Loading

image

@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dev-hunting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 7:16pm

@mr-fox93 mr-fox93 changed the base branch from main to staging May 16, 2024 19:43
Sumick
Sumick requested changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@Sumick Sumick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure if it will fix the problem as we probably can need these children in other place. We should remove that header from different component

mmcode9407
mmcode9407 requested changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@mmcode9407 mmcode9407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to replace the Header with the UserProfileHeader in /moderation/page.
And obviously, you have to leave the children prop in UserProfileMain.
Don't forget about withBackButton prop in UserProfileHeader 👍

@mr-fox93
Copy link
Collaborator Author

I brought it back children in UserProfileMain.
Change Header to UserProfileHeader in page.tsx for ModerationView like said @mmcode9407

mmcode9407
mmcode9407 approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@mmcode9407 mmcode9407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ ❤️

Sumick
Sumick approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Sumick Sumick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🔥

@mr-fox93 mr-fox93 merged commit 5216a5a into staging May 30, 2024
4 checks passed
@mr-fox93 mr-fox93 deleted the fix-remove-header-from-moderation-view-in-user-profile branch May 30, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sumick Sumick Sumick approved these changes

@mmcode9407 mmcode9407 mmcode9407 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-fox93 @Sumick @mmcode9407