Fix prow execution #50
Conversation
electrocucaracha
force-pushed
the
fix_prow
branch
from
2b7efcb to
132fd42
Compare
Signed-off-by: Victor Morales <v.morales@samsung.com>
electrocucaracha
force-pushed
the
fix_prow
branch
from
132fd42 to
9c6d938
Compare
| skip_report: false | ||
| decorate: true | ||
| cluster: default | ||
| extra_refs: |
There was a problem hiding this comment.
why are we removing this?
There was a problem hiding this comment.
That action is redundant, we're cloning the repo during the execution of gce_run.sh script.
| @@ -17,15 +17,10 @@ presubmits: | |||
| - name: e2e | |||
| annotations: | |||
| labels: | |||
| run_if_changed: 'E2E_instance.txt' | |||
| run_if_changed: '^e2e/' | |||
There was a problem hiding this comment.
curious as to what the interpretation of ^e2e/ is?
There was a problem hiding this comment.
My understanding is that this job will be triggered on any change under the e2e folder
|
/lgtm |
|
/lgtm |
|
@aravind254 would appreciate a review and lgtm when you get a chance, Thanks |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, radoslawc, vjayaramrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
gce_run.shbash script is executed from the e2e folder, which causes some issues during the prow execution. This change modifies that behavior to run it from its own folder. This also deprecates the usage ofE2E_instance.txtfile.