Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Vagrant support #29

Merged

Conversation

electrocucaracha
Copy link
Member

These set of changes facilitates the creation of development environments with Vagrant. They don't pretend to replace the current provisioning process.

pip-tools allows to track dependencies on python packages, helping on the
upgrade process. This change intruduces the pip-tools usage as well as improves
the method to consume the python binaries through the pip installation.

Signed-off-by: Victor Morales <v.morales@samsung.com>
ansible-galaxy allows to install roles and collections listed in a
requirements file. This change uses that functionality as well as defines
the versions for every collection used at this point.

Signed-off-by: Victor Morales <v.morales@samsung.com>
This refactor tasks allows to manage all the working files on the home directory
and reduces some repetitive instructions.

Signed-off-by: Victor Morales <v.morales@samsung.com>
The gtp5g module used by free5GC project requires a kernel version <5.4

https://github.com/free5gc/gtp5g/blob/master/README.md

Signed-off-by: Victor Morales <v.morales@samsung.com>
The nephio-ansible-install playbooks require a configuration file to
operate. This change intruduces a minimal sample file for its operation

Signed-off-by: Victor Morales <v.morales@samsung.com>
Vagrant tool allows the creation of local enviroment through the VMs. This
automation reduces the development time and accelates the development. This
changes introduces the Vagrantfile to enable that support.

Signed-off-by: Victor Morales <v.morales@samsung.com>
The shfmt tool helps to provide a format to bash scripts. This standarization
helps to detect some issues. This change facilitates the formatting process.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 4, 2023

Hi @electrocucaracha. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nephio-project nephio-project deleted a comment from nephio-prow bot May 4, 2023
@nephio-project nephio-project deleted a comment from nephio-prow bot May 4, 2023
@radoslawc
Copy link
Collaborator

/ok-to-test

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label May 4, 2023
@radoslawc
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label May 4, 2023
@nephio-prow nephio-prow bot merged commit 38181e5 into nephio-project:main May 4, 2023
@electrocucaracha electrocucaracha deleted the add-vagrant-support branch May 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants