Switching e2e tests to run on main #272

radoslawc · 2024-06-20T07:19:21Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation

/kind failing-test

/kind feature
/kind flake

What this PR does / why we need it:
Switching to main catalog branch
Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

radoslawc · 2024-06-20T07:32:47Z

/test provision-linter

liamfallon · 2024-06-20T08:17:12Z

I found only two more references to v2.0.0 in the end to end tests:

test-infra/e2e/defaults.env

Line 14 in 8d9d67d

export REVISION=${REVISION:-v2.0.0}

The variable "REVISION" is used in a few places:

test-infra/e2e/tests/free5gc/001.sh

Line 48 in 8d9d67d

    
           regional_pkg_rev=$(porchctl rpkg clone -n default "https://github.com/nephio-project/catalog.git/infra/capi/nephio-workload-cluster@$REVISION" --repository mgmt regional | cut -f 1 -d ' ')

test-infra/e2e/tests/free5gc/003.sh

Line 36 in 8d9d67d

    
           pkg_rev=$(porchctl rpkg clone -n default "https://github.com/nephio-project/catalog.git/workloads/free5gc/free5gc-cp@$REVISION" --repository regional free5gc-cp | cut -f 1 -d ' ')

test-infra/e2e/tests/oai/001b-infra-metal-lb.sh

Line 46 in 8d9d67d

    
           pkg_rev=$(porchctl rpkg clone -n default "https://github.com/nephio-project/catalog.git/distros/sandbox/metallb-sandbox-config@$REVISION" --repository mgmt-staging "$cluster-metallb-sandbox-config" | cut -f 1 -d ' ')

Then it looks like we are using a prebuilt version of the v2.0.0 porchctl command here:

test-infra/e2e/provision/playbooks/cluster.yml

Line 133 in 8d9d67d

    
           src: https://github.com/nephio-project/porch/releases/download/v2.0.0/porchctl_2.0.0_linux_amd64.tar.gz

I think that for porchctl we probably should build it from source in the e2e tests to make sure we have the latest version. There are some small changes in porchctl between R2 and R3

radoslawc · 2024-06-20T14:06:03Z

/test bootstrap-integration

electrocucaracha · 2024-06-20T14:32:16Z

@radoslawc It seems like you missed the change on the porch client version. BTW, I suggest completing this issue in this release

liamfallon

This is great!

liamfallon · 2024-06-20T14:36:16Z

/approve

radoslawc · 2024-06-20T14:38:12Z

@radoslawc It seems like you missed the change on the porch client version. BTW, I suggest completing this issue in this release

There's PR to make porchctl builds from main in progress here: nephio-project/porch#77 for now we didn't have them only those build from tags.

liamfallon · 2024-06-20T14:42:23Z

/lgtm

electrocucaracha · 2024-06-20T14:54:59Z

There's PR to make porchctl builds from main in progress here: nephio-project/porch#77 for now we didn't have them only those build from tags.

Ok, so don't forget to move some testing resources to the catalog to centralize the control of versions

/lgtm
/approve

liamfallon · 2024-06-20T15:44:28Z

/retest

radoslawc · 2024-06-20T20:30:38Z

/test e2e-oai-ubuntu-jammy

radoslawc · 2024-06-20T21:54:42Z

/test e2e-free5gc-ubuntu-focal

liamfallon · 2024-06-24T11:55:05Z

/retest

liamfallon · 2024-06-24T12:30:18Z

/retest

liamfallon · 2024-06-24T12:51:37Z

/retest-required

liamfallon · 2024-06-24T13:03:49Z

/test e2e-free5gc-ubuntu-focal

liamfallon · 2024-06-25T09:43:37Z

/test e2e-oai-ubuntu-jammy

liamfallon · 2024-06-25T09:48:19Z

/test e2e-oai-fedora-34

liamfallon · 2024-06-25T13:34:56Z

/approve
/lgtm

liamfallon · 2024-06-25T13:48:04Z

/test bootstrap-integration

liamfallon · 2024-06-25T14:25:37Z

/test bootstrap-integration

radoslawc · 2024-06-25T14:39:14Z

/test bootstrap-integration

electrocucaracha · 2024-06-25T15:47:11Z

@radoslawc @vjayaramrh @liamfallon there is an error on the bootstrap integration test that needs to be fixed. Please take time to review it.

 TASK [bootstrap : Ensure gtp5g kernel constraints] *****************************
fatal: [int-focal-vm-bootstrap-3299538048]: FAILED! => {"msg": "The conditional check 'ansible_facts.kernel == \"5.0.0-23-generic\" or True' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."}

liamfallon · 2024-06-25T16:04:46Z

@radoslawc @vjayaramrh @liamfallon there is an error on the bootstrap integration test that needs to be fixed. Please take time to review it.
 TASK [bootstrap : Ensure gtp5g kernel constraints] *****************************
fatal: [int-focal-vm-bootstrap-3299538048]: FAILED! => {"msg": "The conditional check 'ansible_facts.kernel == \"5.0.0-23-generic\" or True' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."} 

Thanks @electrocucaracha , we'll check it.

Fix for FAILED! => {"msg": "The conditional check 'ansible_facts.kernel == \"5.0.0-23-generic\" or True' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."}

radoslawc · 2024-06-25T16:47:29Z

/test bootstrap-integration

radoslawc · 2024-06-25T16:54:20Z

@electrocucaracha @liamfallon now bootstrap-integration fails on:

TASK [Gathering Facts] *********************************************************
fatal: [int-focal-vm-bootstrap-659977273]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: root@34.170.197.210: Permission denied (publickey).", "unreachable": true}

Only change was removing curly braces like in https://github.com/nephio-project/test-infra/pull/278/files where it worked afterwards.

electrocucaracha · 2024-06-25T17:00:17Z

@electrocucaracha @liamfallon now bootstrap-integration fails on:
TASK [Gathering Facts] *********************************************************
fatal: [int-focal-vm-bootstrap-659977273]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: root@34.170.197.210: Permission denied (publickey).", "unreachable": true}
Only change was removing curly braces like in https://github.com/nephio-project/test-infra/pull/278/files where it worked afterwards.

There is a tech debt on the integration tests, I'm not sure if it's conflicting with other existing VMs or sometimes GCP can't smoothly create those molecule instances. Usually those errors are gone in the second try, but definitely it's necessary to investigate the root cause

/test bootstrap-integration

radoslawc · 2024-06-25T17:15:52Z

/test bootstrap-integration

liamfallon · 2024-06-25T21:02:19Z

/lgtm
/approve

nephio-prow · 2024-06-25T21:02:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [electrocucaracha,liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

liamfallon · 2024-06-25T21:04:11Z

/test e2e-oai-ubuntu-jammy

liamfallon · 2024-06-25T21:05:11Z

/test e2e-oai-fedora-34

liamfallon · 2024-06-25T21:13:52Z

/test e2e-oai-fedora-34

liamfallon · 2024-06-25T21:19:50Z

/test e2e-oai-ubuntu-jammy

liamfallon · 2024-06-25T21:34:19Z

/test e2e-oai-fedora-34
/test e2e-oai-ubuntu-jammy

vjayaramrh · 2024-06-25T22:03:25Z

/test e2e-oai-ubuntu-jammy

nephio-prow · 2024-06-25T22:21:57Z

@radoslawc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
e2e-oai-fedora-34	`d24412f`	link	false	`/test e2e-oai-fedora-34`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

electrocucaracha · 2024-06-26T02:06:48Z

@radoslawc @liamfallon @vjayaramrh be cautious to use retest prow commands, every error is an opportunity to improve the resiliency of the CI. Forcing some jobs can lead to future problems.

liamfallon · 2024-06-26T05:33:52Z

@radoslawc @liamfallon @vjayaramrh be cautious to use retest prow commands, every error is an opportunity to improve the resiliency of the CI. Forcing some jobs can lead to future problems.

I opened this discussion:
nephio-project/nephio#774

* Switching e2e tests to run on main * Adjusting defaults.env to use main * Switching porchctl to latest binary build * Update load-gtp5g-module.yml Fix for FAILED! => {"msg": "The conditional check 'ansible_facts.kernel == \"5.0.0-23-generic\" or True' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."}

Switching e2e tests to run on main

b75a35d

nephio-prow bot added the kind/failing-test label Jun 20, 2024

nephio-prow bot requested review from electrocucaracha and liamfallon June 20, 2024 07:19

Adjusting defaults.env to use main

56f3df3

radoslawc requested review from efiacor and vjayaramrh June 20, 2024 14:31

liamfallon reviewed Jun 20, 2024

View reviewed changes

nephio-prow bot assigned liamfallon Jun 20, 2024

nephio-prow bot added the lgtm label Jun 20, 2024

nephio-prow bot assigned electrocucaracha Jun 20, 2024

nephio-prow bot added the approved label Jun 20, 2024

Switching porchctl to latest binary build

49a4239

nephio-prow bot removed the lgtm label Jun 20, 2024

Merge branch 'main' into catalog_switch

a844d7c

nephio-prow bot added the lgtm label Jun 25, 2024

Merge branch 'nephio-project:main' into catalog_switch

31d7bd3

nephio-prow bot removed the lgtm label Jun 25, 2024

Update load-gtp5g-module.yml

d24412f

Fix for FAILED! => {"msg": "The conditional check 'ansible_facts.kernel == \"5.0.0-23-generic\" or True' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."}

nephio-prow bot added the lgtm label Jun 25, 2024

nephio-prow bot merged commit 4c34808 into nephio-project:main Jun 25, 2024
7 of 8 checks passed

Switching e2e tests to run on main #272

Switching e2e tests to run on main #272

Conversation

radoslawc commented Jun 20, 2024

radoslawc commented Jun 20, 2024

liamfallon commented Jun 20, 2024 • edited Loading

radoslawc commented Jun 20, 2024

electrocucaracha commented Jun 20, 2024

liamfallon left a comment

Choose a reason for hiding this comment

liamfallon commented Jun 20, 2024

radoslawc commented Jun 20, 2024

liamfallon commented Jun 20, 2024

electrocucaracha commented Jun 20, 2024

liamfallon commented Jun 20, 2024

radoslawc commented Jun 20, 2024

radoslawc commented Jun 20, 2024

liamfallon commented Jun 24, 2024

liamfallon commented Jun 24, 2024

liamfallon commented Jun 24, 2024

liamfallon commented Jun 24, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

radoslawc commented Jun 25, 2024

electrocucaracha commented Jun 25, 2024

liamfallon commented Jun 25, 2024

radoslawc commented Jun 25, 2024

radoslawc commented Jun 25, 2024

electrocucaracha commented Jun 25, 2024

radoslawc commented Jun 25, 2024

liamfallon commented Jun 25, 2024

nephio-prow bot commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

liamfallon commented Jun 25, 2024

vjayaramrh commented Jun 25, 2024

nephio-prow bot commented Jun 25, 2024 • edited Loading

electrocucaracha commented Jun 26, 2024

liamfallon commented Jun 26, 2024

liamfallon commented Jun 20, 2024 •

edited

Loading

nephio-prow bot commented Jun 25, 2024 •

edited

Loading